-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[pkg/ottl] Add function ProfileID() #39587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
atoulme
merged 7 commits into
open-telemetry:main
from
rockdaboot:profiles-add-ProfileID-func
Apr 29, 2025
Merged
[pkg/ottl] Add function ProfileID() #39587
atoulme
merged 7 commits into
open-telemetry:main
from
rockdaboot:profiles-add-ProfileID-func
Apr 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf30889
to
9a6c758
Compare
florianl
reviewed
Apr 24, 2025
edmocosta
reviewed
Apr 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add an e2e test for the new converter? similar to the existing SpanID.
florianl
approved these changes
Apr 25, 2025
edmocosta
approved these changes
Apr 25, 2025
TylerHelmuth
pushed a commit
that referenced
this pull request
Apr 28, 2025
#### Description Disallow setting empty profile IDs via the OTTL accessor. See discussion at #39587 (comment)
atoulme
approved these changes
Apr 29, 2025
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 6, 2025
…39659) #### Description Disallow setting empty profile IDs via the OTTL accessor. See discussion at open-telemetry#39587 (comment)
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 6, 2025
#### Description Add the OTTL function `ProfileID()`, which is currently missing.
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 20, 2025
#### Description Add the OTTL function `ProfileID()`, which is currently missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the OTTL function
ProfileID()
, which is currently missing.