Skip to content

[pkg/ottl] Add function ProfileID() #39587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 29, 2025

Conversation

rockdaboot
Copy link
Contributor

Description

Add the OTTL function ProfileID(), which is currently missing.

@rockdaboot rockdaboot force-pushed the profiles-add-ProfileID-func branch from bf30889 to 9a6c758 Compare April 23, 2025 15:49
@rockdaboot rockdaboot changed the title [chore] [pkg/ottl] Add function ProfileID() [pkg/ottl] Add function ProfileID() Apr 23, 2025
@rockdaboot rockdaboot marked this pull request as ready for review April 23, 2025 15:50
@rockdaboot rockdaboot requested a review from a team as a code owner April 23, 2025 15:50
Copy link
Contributor

@edmocosta edmocosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add an e2e test for the new converter? similar to the existing SpanID.

TylerHelmuth pushed a commit that referenced this pull request Apr 28, 2025
#### Description
Disallow setting empty profile IDs via the OTTL accessor.

See discussion at
#39587 (comment)
@atoulme atoulme merged commit eec1d95 into open-telemetry:main Apr 29, 2025
173 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 29, 2025
vincentfree pushed a commit to ing-bank/opentelemetry-collector-contrib that referenced this pull request May 6, 2025
…39659)

#### Description
Disallow setting empty profile IDs via the OTTL accessor.

See discussion at
open-telemetry#39587 (comment)
vincentfree pushed a commit to ing-bank/opentelemetry-collector-contrib that referenced this pull request May 6, 2025
#### Description
Add the OTTL function `ProfileID()`, which is currently missing.
vincentfree pushed a commit to ing-bank/opentelemetry-collector-contrib that referenced this pull request May 20, 2025
#### Description
Add the OTTL function `ProfileID()`, which is currently missing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants