[receiver/postgresql] add basic query sample collection for postgresqlreceiver #39573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor-contrib into top-queries
…ector-contrib into top-queries
atoulme
reviewed
Apr 25, 2025
atoulme
reviewed
Apr 25, 2025
atoulme
reviewed
Apr 25, 2025
|
|
||
| p.collectTopQuery(ctx, dbClient, &logRecords, maxRowsPerQuery, topNQuery, &errs, p.logger) | ||
|
|
||
| defer dbClient.Close() |
There was a problem hiding this comment.
should the defer call be before we collect?
atoulme
reviewed
Apr 25, 2025
atoulme
approved these changes
Apr 25, 2025
|
Moving to draft, please address comments and mark ready for review. |
…tor-contrib into top-queries
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 6, 2025
…lreceiver (open-telemetry#39573) #### Description we introduced the top query collection to postgresql receiver. this will collect the queries from `pg_stat_statements` and report the related metrics. this will help the end user to identify which queries are most executed, and resources most used. Example output: ``` resourceLogs: - resource: attributes: [] scopeLogs: - logRecords: - attributes: - key: db.system.name value: stringValue: postgresql - key: db.namespace value: stringValue: postgres - key: db.query.text value: stringValue: "select * from pg_stat_activity where id = ?" - key: postgresql.calls value: intValue: 3 - key: postgresql.rows value: intValue: 10 - key: postgresql.shared_blks_dirtied value: intValue: 1 - key: postgresql.shared_blks_hit value: intValue: 2 - key: postgresql.shared_blks_read value: intValue: 3 - key: postgresql.shared_blks_written value: intValue: 4 - key: postgresql.temp_blks_read value: intValue: 5 - key: postgresql.temp_blks_written value: intValue: 6 - key: postgresql.queryid value: stringValue: "114514" - key: postgresql.rolname value: stringValue: master - key: postgresql.total_exec_time value: doubleValue: 1 - key: postgresql.total_plan_time value: doubleValue: 1 body: stringValue: top query scope: name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver version: 0.0.1 ```
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 20, 2025
…lreceiver (open-telemetry#39573) #### Description we introduced the top query collection to postgresql receiver. this will collect the queries from `pg_stat_statements` and report the related metrics. this will help the end user to identify which queries are most executed, and resources most used. Example output: ``` resourceLogs: - resource: attributes: [] scopeLogs: - logRecords: - attributes: - key: db.system.name value: stringValue: postgresql - key: db.namespace value: stringValue: postgres - key: db.query.text value: stringValue: "select * from pg_stat_activity where id = ?" - key: postgresql.calls value: intValue: 3 - key: postgresql.rows value: intValue: 10 - key: postgresql.shared_blks_dirtied value: intValue: 1 - key: postgresql.shared_blks_hit value: intValue: 2 - key: postgresql.shared_blks_read value: intValue: 3 - key: postgresql.shared_blks_written value: intValue: 4 - key: postgresql.temp_blks_read value: intValue: 5 - key: postgresql.temp_blks_written value: intValue: 6 - key: postgresql.queryid value: stringValue: "114514" - key: postgresql.rolname value: stringValue: master - key: postgresql.total_exec_time value: doubleValue: 1 - key: postgresql.total_plan_time value: doubleValue: 1 body: stringValue: top query scope: name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver version: 0.0.1 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
we introduced the top query collection to postgresql receiver. this will collect the queries from
pg_stat_statementsand report the related metrics. this will help the end user to identify which queries are most executed, and resources most used.Example output: