-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add Multiple Metrics About Search Performance to splunkenterprisereceiver #39569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Multiple Metrics About Search Performance to splunkenterprisereceiver #39569
Conversation
* Initial commit * Corrected structs to fit json API response * Added to changelog * PR number added to changelog
Almost there - some lint issues:
|
Moving to draft while this is being worked on. Please move back to ready when done. |
splunk.search.status: | ||
enabled: false | ||
splunk.search.success: | ||
enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this no the same thing? One is just the count of the other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dispatchState
property can have many different states so we capture that in splunk.search.status
while splunk.search.success
is more of a convience metrics that is a quick signal to knowing that the submitted searches have readed the dispatchState
of DONE
9b9b21f
to
b2b48ac
Compare
…iver (open-telemetry#39569) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Added a new `splunk.search.initiation`, `splunk.search.duration`, `splunk.search.status`, and `splunk.search.success` metrics. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#39566 <!--Describe what testing was performed and which tests were added.--> #### Testing Ran on a test stack and observed the metrics in Splunk Observability  <!--Describe the documentation added.--> #### Documentation The only documentation added was the generated documentation about the newly added metrics. <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Sean Marciniak <[email protected]>
…iver (open-telemetry#39569) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Added a new `splunk.search.initiation`, `splunk.search.duration`, `splunk.search.status`, and `splunk.search.success` metrics. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#39566 <!--Describe what testing was performed and which tests were added.--> #### Testing Ran on a test stack and observed the metrics in Splunk Observability  <!--Describe the documentation added.--> #### Documentation The only documentation added was the generated documentation about the newly added metrics. <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Sean Marciniak <[email protected]>
Description
Added a new
splunk.search.initiation
,splunk.search.duration
,splunk.search.status
, andsplunk.search.success
metrics.Link to tracking issue
Fixes #39566
Testing
Ran on a test stack and observed the metrics in Splunk Observability

Documentation
The only documentation added was the generated documentation about the newly added metrics.