[receiver/kubeletstats] Move receiver.kubeletstats.enableCPUUsageMetrics feature gate to beta #39488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odubajDT
commented
Apr 18, 2025
| @@ -57,6 +57,31 @@ func newKubeletScraper( | |||
| metricsConfig metadata.MetricsBuilderConfig, | |||
| nodeName string, | |||
| ) (scraper.Metrics, error) { | |||
| if EnableCPUUsageMetrics.IsEnabled() { | |||
There was a problem hiding this comment.
this logic was moved to scraper due to easier testability -> all tests are using newKubeletScraper() function to initialize the scraper and test the exported metrics and therefore if the logic is present in the factory, there is no possibility to test the new behavior.
There was a problem hiding this comment.
How about moving this check to the config validation?
There was a problem hiding this comment.
We dont want to do that bc the result of the gate may change the config and generally it is a bad practice to modify the config in the validate function
metricsConfig.Metrics.ContainerCPUUtilization.Enabled = true
metricsConfig.Metrics.K8sPodCPUUtilization.Enabled = true
metricsConfig.Metrics.K8sNodeCPUUtilization.Enabled = true
ChrsMark
reviewed
Apr 22, 2025
…ics feature gate to beta Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
odubajDT
force-pushed
the
kubeletstats-feature-gate
branch
from
38cd820 to
48a4719
Compare
ChrsMark
approved these changes
Apr 23, 2025
iblancasa
approved these changes
Apr 23, 2025
| @@ -57,6 +57,31 @@ func newKubeletScraper( | |||
| metricsConfig metadata.MetricsBuilderConfig, | |||
| nodeName string, | |||
| ) (scraper.Metrics, error) { | |||
| if EnableCPUUsageMetrics.IsEnabled() { | |||
There was a problem hiding this comment.
How about moving this check to the config validation?
TylerHelmuth
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking issue
Fixes #39487
Related to #27885