[stanza] Remove unnecessary slice allocation to track errors (even nil) #39367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
djaglowski,
andrzej-stencel and
a team
as code owners
bogdandrutu
commented
Apr 12, 2025
Comment on lines
+81
to
+86
| var errs error | ||
| for i := range entries { | ||
| errs = append(errs, process(ctx, entries[i])) | ||
| errs = multierr.Append(errs, process(ctx, entries[i])) | ||
| } | ||
| return errors.Join(errs...) | ||
| return errs |
There was a problem hiding this comment.
This caused an unnecessary slice allocation.
bogdandrutu
force-pushed
the
stanza-error
branch
from
43d88ab to
31fa75b
Compare
atoulme
approved these changes
Apr 13, 2025
djaglowski
approved these changes
Apr 13, 2025
|
LGTM in principle. Please address CI failures. |
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
stanza-error
branch
from
31fa75b to
9f0f75f
Compare
akshays-19
pushed a commit
to akshays-19/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…l) (open-telemetry#39367) The most inefficient usages are in ProcessBatch and ProcessBatchWith, where we allocate a slice of errors even if return value is nil. Changed all usages to make sure we don't repeat that mistake and establish a healthier pattern. Signed-off-by: Bogdan Drutu <[email protected]>
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…l) (open-telemetry#39367) The most inefficient usages are in ProcessBatch and ProcessBatchWith, where we allocate a slice of errors even if return value is nil. Changed all usages to make sure we don't repeat that mistake and establish a healthier pattern. Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most inefficient usages are in ProcessBatch and ProcessBatchWith, where we allocate a slice of errors even if return value is nil.
Changed all usages to make sure we don't repeat that mistake and establish a healthier pattern.