Skip to content

[exporter/loadbalancing] update README and include attributes routing key #39107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rlankfo
Copy link
Member

@rlankfo rlankfo commented Apr 1, 2025

Description

Doc update related to #36567

Documentation

Adds attributes routing_key to table in README and a minor documentation fix.

Copy link
Contributor

@dehaansa dehaansa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved, and reconsidered - we should skip changelog for a docs-only change like this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me! removed.

@dehaansa dehaansa added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 2, 2025
@dehaansa dehaansa added the ready to merge Code review completed; ready to merge by maintainers label Apr 3, 2025
@songy23 songy23 merged commit 93d2ba3 into open-telemetry:main Apr 3, 2025
160 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 3, 2025
dmathieu pushed a commit to dmathieu/opentelemetry-collector-contrib that referenced this pull request Apr 8, 2025
… key (open-telemetry#39107)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Doc update related to
open-telemetry#36567

<!--Describe the documentation added.-->
#### Documentation
Adds attributes routing_key to table in README and a minor documentation
fix.

---------

Signed-off-by: Robbie Lankford <[email protected]>
Fiery-Fenix pushed a commit to Fiery-Fenix/opentelemetry-collector-contrib that referenced this pull request Apr 24, 2025
… key (open-telemetry#39107)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Doc update related to
open-telemetry#36567

<!--Describe the documentation added.-->
#### Documentation
Adds attributes routing_key to table in README and a minor documentation
fix.

---------

Signed-off-by: Robbie Lankford <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/loadbalancing ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants