[receiver/stef] Add enough code to make the stefreceiver function #39044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
requested review from
tigrannajaryan,
MovieStoreGuy,
dmitryax,
crobert-1 and
a team
as code owners
atoulme
force-pushed
the
stefreceiver
branch
3 times, most recently
from
072000a to
c89127f
Compare
| // Create a responder for this stream and run it in a separate goroutine. | ||
| resp := internal.NewResponder(r.settings.Logger, stream) | ||
| defer resp.Stop() | ||
| go resp.Run() |
There was a problem hiding this comment.
Using errgroup.Group here?
There was a problem hiding this comment.
that didn't really work out, but maybe a different way to build this interaction would make sense
pjanotti
reviewed
Apr 1, 2025
| - `endpoint` (default = localhost:4320 for grpc protocol): | ||
| host:port to which the receiver is going to receive data. The valid syntax is | ||
| described at https://github.com/grpc/grpc/blob/master/doc/naming.md. | ||
| - `ack_interval` (default: 10ms). The periodical interval of time when sending acknowledgements back to the client. |
There was a problem hiding this comment.
side Q.: how was this default value chosen? Without any context, at first, it seems too frequent.
There was a problem hiding this comment.
it's not that frequent ; it's 10ms as a gRPC response on an established TCP stream. You could say, if it's just a single message exchange, that it's a bit high. I think it will need to be revisited to be more adaptive moving forward.
The 10ms is just to avoid spamming with responses every time data is consumed. By waiting 10ms, the code sends responses less often, which is best when dealing with a constant stream of data.
pjanotti
reviewed
Apr 1, 2025
pjanotti
approved these changes
Apr 2, 2025
tigrannajaryan
approved these changes
Apr 2, 2025
crobert-1
approved these changes
Apr 2, 2025
Co-authored-by: Curtis Robert <[email protected]>
dmathieu
pushed a commit
to dmathieu/opentelemetry-collector-contrib
that referenced
this pull request
Apr 8, 2025
…en-telemetry#39044) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds just enough code to make the stefreceiver work. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#38979 <!--Describe what testing was performed and which tests were added.--> #### Testing Roundtrip with the exporter <!--Describe the documentation added.--> #### Documentation README <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Curtis Robert <[email protected]>
LucianoGiannotti
pushed a commit
to LucianoGiannotti/opentelemetry-collector-contrib
that referenced
this pull request
Apr 9, 2025
…en-telemetry#39044) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds just enough code to make the stefreceiver work. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#38979 <!--Describe what testing was performed and which tests were added.--> #### Testing Roundtrip with the exporter <!--Describe the documentation added.--> #### Documentation README <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Curtis Robert <[email protected]>
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…en-telemetry#39044) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds just enough code to make the stefreceiver work. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#38979 <!--Describe what testing was performed and which tests were added.--> #### Testing Roundtrip with the exporter <!--Describe the documentation added.--> #### Documentation README <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Curtis Robert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds just enough code to make the stefreceiver work.
Link to tracking issue
Fixes #38979
Testing
Roundtrip with the exporter
Documentation
README