[receiver/azuremonitorreceiver] feat: add subscription name resource attribute #39029
Conversation
celian-garcia
force-pushed
the
azuremonitorreceiver/add-subscription-name
branch
4 times, most recently
from
b06e2ac to
bae186c
Compare
celian-garcia
force-pushed
the
azuremonitorreceiver/add-subscription-name
branch
from
bae186c to
165023e
Compare
|
@dehaansa, from your comments I updated so the GET subscription by ID is only done if the subscription name resource attribute is enabled in the config. |
| ```yaml | ||
| conditions: | ||
| - discover_subscriptions is true | ||
| cardinality: once |
There was a problem hiding this comment.
This is a paged API, right? So it may be more than once depending on the number of subscriptions. Same for other List endpoints.
There was a problem hiding this comment.
That's true yes, I updated with that precision. Unfortunately I didn't find the page size in the API documentation or client codes. This is a mystery that Azure seems to keep secret deep in the backend ^^'
celian-garcia
force-pushed
the
azuremonitorreceiver/add-subscription-name
branch
from
165023e to
2b0ca13
Compare
…attribute Signed-off-by: Célian Garcia <[email protected]>
celian-garcia
force-pushed
the
azuremonitorreceiver/add-subscription-name
branch
from
2b0ca13 to
f4ab492
Compare
dehaansa
added
ready to merge
|
I need to do a better job checking the codeowners file before marking the waiting-for-code-owners label, oops! |
Aah my bad 😁 I thought it was meaning code owners with bigger rights. Btw the other owner of that receiver stopped answering months ago. I think he's not working on that at all anymore. |
|
I think the Prometheus tests failing are flaky ones. It seems not related. I tried to update branch but it didn't change. It's not urgent anyway, I can wait fo a fix. |
|
Just confirming, the prometheus-compliance-tests are broken until prometheus/compliance#160 is resolved. I attempted to disable the workflow at the repository level but it may not have worked right, looking into it. |
…attribute (open-telemetry#39029) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The subscription name is often more speaking for people playing with metrics, than the subscription id which is an uuid. Hence this PR. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Linked with open-telemetry#38895. I prefer to have a separate PR for the add of subscription name in resource attributes to have one PR by feature. <!--Describe what testing was performed and which tests were added.--> #### Testing Added unit tests + new mock API to mock the new get by subscription calls. <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Signed-off-by: Célian Garcia <[email protected]> Co-authored-by: Antoine Toulme <[email protected]>
…attribute (open-telemetry#39029) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The subscription name is often more speaking for people playing with metrics, than the subscription id which is an uuid. Hence this PR. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Linked with open-telemetry#38895. I prefer to have a separate PR for the add of subscription name in resource attributes to have one PR by feature. <!--Describe what testing was performed and which tests were added.--> #### Testing Added unit tests + new mock API to mock the new get by subscription calls. <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Signed-off-by: Célian Garcia <[email protected]> Co-authored-by: Antoine Toulme <[email protected]>
…attribute (open-telemetry#39029) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The subscription name is often more speaking for people playing with metrics, than the subscription id which is an uuid. Hence this PR. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Linked with open-telemetry#38895. I prefer to have a separate PR for the add of subscription name in resource attributes to have one PR by feature. <!--Describe what testing was performed and which tests were added.--> #### Testing Added unit tests + new mock API to mock the new get by subscription calls. <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Signed-off-by: Célian Garcia <[email protected]> Co-authored-by: Antoine Toulme <[email protected]>
Description
The subscription name is often more speaking for people playing with metrics, than the subscription id which is an uuid.
Hence this PR.
Link to tracking issue
Linked with #38895. I prefer to have a separate PR for the add of subscription name in resource attributes to have one PR by feature.
Testing
Added unit tests + new mock API to mock the new get by subscription calls.
Documentation