fix(telemetrygen): fix histogram data points to comply with spec #39025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
reviewed
Mar 27, 2025
There was a problem hiding this comment.
Thanks for the fix @ianwilkes! if you can add a changelog entry and mark this as a bugfix for the telemetrygen component, that'd be fantastic
I see you already submitted a changelog :D
codeboten
approved these changes
Mar 27, 2025
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…n-telemetry#39025) #### Description The HistogramDataPoint message has a couple of clear rules: the Count field must equal the total count of all buckets (if present), and the length of the bucket array must be one greater than the length of the boundary array. This fixes the telemetrygen histograms to conform to these rules. See https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/metrics/v1/metrics.proto#L443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The HistogramDataPoint message has a couple of clear rules: the Count field must equal the total count of all buckets (if present), and the length of the bucket array must be one greater than the length of the boundary array. This fixes the telemetrygen histograms to conform to these rules.
See https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/metrics/v1/metrics.proto#L443