-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[chore] Add cgroupruntime extension integration tests #39017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Add cgroupruntime extension integration tests #39017
Conversation
57c1f8e
to
a28617f
Compare
Looks like the integration test is flaky: My guess is that the tests modifies the cpu and memory limits and as GitHub-hosted runners have strict resource limits it kills the process/test. Checking if we could reduce the resource changes limits. |
Memory usage of the tests:
The integration tests were setting the cgroup max memory to the 10% of 128 Mb, thus in some runs triggering the OOM killer -> Increasing the cgroup max memory setting from 128Mb to 4GB (should not be an issue if the system has less total memory) seems to fix the issue. |
@@ -7,6 +7,7 @@ status: | |||
distributions: [contrib] | |||
codeowners: | |||
active: [mx-psi, rogercoll] | |||
unsupported_platforms: [darwin, windows] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not related to the test you're adding?
…#39017) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Reverts open-telemetry#37224 with a few additional changes: - Decouple `sudo` integration tests from non-privileged ones from the makefile. -> **prevent sudo promp when running integration tests** - Adds a specific `intengration-sudo-tests` check in the CI that only targets the cgroupruntime extension as being the only component that currently requires this setup. - Sets darwin and windows as unsupported platforms (it requires cgroup file system). <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue [Fixes](open-telemetry#36545) <!--Describe what testing was performed and which tests were added.--> #### Testing Adds the integration tests required for is addition into the contrib binary. <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Antoine Toulme <[email protected]>
…#39017) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Reverts open-telemetry#37224 with a few additional changes: - Decouple `sudo` integration tests from non-privileged ones from the makefile. -> **prevent sudo promp when running integration tests** - Adds a specific `intengration-sudo-tests` check in the CI that only targets the cgroupruntime extension as being the only component that currently requires this setup. - Sets darwin and windows as unsupported platforms (it requires cgroup file system). <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue [Fixes](open-telemetry#36545) <!--Describe what testing was performed and which tests were added.--> #### Testing Adds the integration tests required for is addition into the contrib binary. <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Antoine Toulme <[email protected]>
…#39017) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Reverts open-telemetry#37224 with a few additional changes: - Decouple `sudo` integration tests from non-privileged ones from the makefile. -> **prevent sudo promp when running integration tests** - Adds a specific `intengration-sudo-tests` check in the CI that only targets the cgroupruntime extension as being the only component that currently requires this setup. - Sets darwin and windows as unsupported platforms (it requires cgroup file system). <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue [Fixes](open-telemetry#36545) <!--Describe what testing was performed and which tests were added.--> #### Testing Adds the integration tests required for is addition into the contrib binary. <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Antoine Toulme <[email protected]>
Description
Reverts #37224 with a few additional changes:
sudo
integration tests from non-privileged ones from the makefile. -> prevent sudo promp when running integration testsintengration-sudo-tests
check in the CI that only targets the cgroupruntime extension as being the only component that currently requires this setup.Link to tracking issue
Fixes
Testing
Adds the integration tests required for is addition into the contrib binary.
Documentation