Skip to content

[pkg/testdata] Fix type of Attribute.Value for profiles #39006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2025

Conversation

rockdaboot
Copy link
Contributor

The value type is string, but it should be any.

@rockdaboot rockdaboot force-pushed the profiles-testdata-fix branch from 4921b34 to b2186fc Compare March 27, 2025 11:51
@rockdaboot rockdaboot marked this pull request as ready for review March 27, 2025 11:51
@rockdaboot rockdaboot requested a review from a team as a code owner March 27, 2025 11:51
Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about testing those with non-string values?

@rockdaboot
Copy link
Contributor Author

How about testing those with non-string values?

Added a test with a boolean attribute value.

@atoulme atoulme merged commit d36dbab into open-telemetry:main Mar 27, 2025
171 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 27, 2025
Fiery-Fenix pushed a commit to Fiery-Fenix/opentelemetry-collector-contrib that referenced this pull request Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants