kafkareceiver: add signal-specific topic/encoding #38985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
commented
Mar 26, 2025
Add signal-specific configuration for topic and encoding. The topics are already signal-specific by default, it just hasn't been possible to explicitly configure a different topic for each signal. Thus if you set the `topic: foo`, it would be used for all signals, which is never going to work with the receiver. Similarly, while the default encoding is the same for all signals (i.e. otlp_proto), some encodings are available only for certain signals, e.g. azure_resource_logs is (obviously) only available for logs. This means you could not use the same receiver for multiple signals unless they each used the same encoding. To address both of these issues we introduce signal-specific configuration: `logs::topic`, `metrics::topic`, `traces::topic`, `logs::encoding`, `metrics::encoding`, and `traces::encoding`. The existing `topic` and `encoding` configuration have been deprecated. If the new fields are set, they will take precedence; otherwise if the deprecated fields are set they will be used. The defaults have not changed. Fixes open-telemetry#32735
axw
force-pushed
the
kafkareceiver-persignal-config
branch
from
69bf554 to
063f012
Compare
MovieStoreGuy
approved these changes
Apr 11, 2025
akshays-19
pushed a commit
to akshays-19/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
#### Description Add signal-specific configuration for topic and encoding. The topics are already signal-specific by default, it just hasn't been possible to explicitly configure a different topic for each signal. Thus if you set the `topic: foo`, it would be used for all signals, which is never going to work with the receiver. Similarly, while the default encoding is the same for all signals (i.e. otlp_proto), some encodings are available only for certain signals, e.g. azure_resource_logs is (obviously) only available for logs. This means you could not use the same receiver for multiple signals unless they each used the same encoding. To address both of these issues we introduce signal-specific configuration: `logs::topic`, `metrics::topic`, `traces::topic`, `logs::encoding`, `metrics::encoding`, and `traces::encoding`. The existing `topic` and `encoding` configuration have been deprecated. If the new fields are set, they will take precedence; otherwise if the deprecated fields are set they will be used. The defaults have not changed. #### Link to tracking issue Fixes open-telemetry#32735 #### Testing Unit tests added. #### Documentation README updated.
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
#### Description Add signal-specific configuration for topic and encoding. The topics are already signal-specific by default, it just hasn't been possible to explicitly configure a different topic for each signal. Thus if you set the `topic: foo`, it would be used for all signals, which is never going to work with the receiver. Similarly, while the default encoding is the same for all signals (i.e. otlp_proto), some encodings are available only for certain signals, e.g. azure_resource_logs is (obviously) only available for logs. This means you could not use the same receiver for multiple signals unless they each used the same encoding. To address both of these issues we introduce signal-specific configuration: `logs::topic`, `metrics::topic`, `traces::topic`, `logs::encoding`, `metrics::encoding`, and `traces::encoding`. The existing `topic` and `encoding` configuration have been deprecated. If the new fields are set, they will take precedence; otherwise if the deprecated fields are set they will be used. The defaults have not changed. #### Link to tracking issue Fixes open-telemetry#32735 #### Testing Unit tests added. #### Documentation README updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add signal-specific configuration for topic and encoding.
The topics are already signal-specific by default, it just hasn't been possible to explicitly configure a different topic for each signal. Thus if you set the
topic: foo, it would be used for all signals, which is never going to work with the receiver.Similarly, while the default encoding is the same for all signals (i.e. otlp_proto), some encodings are available only for certain signals, e.g. azure_resource_logs is (obviously) only available for logs. This means you could not use the same receiver for multiple signals unless they each used the same encoding.
To address both of these issues we introduce signal-specific configuration:
logs::topic,metrics::topic,traces::topic,logs::encoding,metrics::encoding, andtraces::encoding.The existing
topicandencodingconfiguration have been deprecated. If the new fields are set, they will take precedence; otherwise if the deprecated fields are set they will be used. The defaults have not changed.Link to tracking issue
Fixes #32735
Testing
Unit tests added.
Documentation
README updated.