Avoid embedding the QueueConfig, avoids potential conflicts #38887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
tigrannajaryan,
dmitryax,
a team and
dehaansa
as code owners
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
queueconfig
branch
from
e5feed4 to
4731e70
Compare
MovieStoreGuy
approved these changes
Mar 24, 2025
tigrannajaryan
approved these changes
Mar 24, 2025
rlankfo
approved these changes
Mar 24, 2025
atoulme
approved these changes
Mar 24, 2025
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…emetry#38887) This fixes a bug if we add same variable names as in RetryConfig will conflict with QueueConfig even though by the yaml they are allowed. Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug if we add same variable names as in RetryConfig will conflict with QueueConfig even though by the yaml they are allowed.