kafka: deprecate redundant auth.plain_text #38883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
dmitryax,
MovieStoreGuy and
pavolloffay
If `auth.plain_text` is configured, internally
SASL/PLAIN is configured.
This config is redundant and makes things harder
to understand: as a user, should I configure
auth.plain_text, or auth.sasl with mechanism PLAIN?
If I set plain_text I can't specify the SASL protocol
version, why not?
So let's simplify, at the expense of slightly more
verbose, but more explicit, configuration. Instead of
configuring:
```yaml
auth:
plain_text:
username: alice
password: bob
```
... you should configure this instead:
```yaml
auth:
sasl:
mechanism: PLAIN
username: alice
password: bob
```
axw
force-pushed
the
kafka-deprecate-plaintext
branch
from
869eb5b to
81968ea
Compare
MovieStoreGuy
approved these changes
Mar 24, 2025
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
#### Description
If `auth.plain_text` is configured, internally SASL/PLAIN is configured.
This config is redundant and makes things harder to understand: as a
user, should I configure auth.plain_text, or auth.sasl with mechanism
PLAIN? If I set plain_text I can't specify the SASL protocol version,
why not?
So let's simplify, at the expense of slightly more verbose, but more
explicit, configuration. Instead of configuring:
```yaml
auth:
plain_text:
username: alice
password: bob
```
... you should configure this instead:
```yaml
auth:
sasl:
mechanism: PLAIN
username: alice
password: bob
```
#### Link to tracking issue
None
#### Testing
N/A
#### Documentation
Updated READMEs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If
auth.plain_textis configured, internally SASL/PLAIN is configured.This config is redundant and makes things harder to understand: as a user, should I configure auth.plain_text, or auth.sasl with mechanism PLAIN? If I set plain_text I can't specify the SASL protocol version, why not?
So let's simplify, at the expense of slightly more verbose, but more explicit, configuration. Instead of configuring:
... you should configure this instead:
Link to tracking issue
None
Testing
N/A
Documentation
Updated READMEs.