[receiver/kafka][exporter/kafka] Do not expose programmatic API via NewFactory #38874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
implement_factory_api
branch
from
4eab95a to
44d6ff1
Compare
atoulme
force-pushed
the
implement_factory_api
branch
from
44d6ff1 to
8b95179
Compare
This was referenced Mar 23, 2025
MovieStoreGuy
approved these changes
Mar 24, 2025
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…ewFactory (open-telemetry#38874) #### Description It seems suspect to offer a FactoryFunc func on both kafka receivers and exporters, when they don't offer any changes to the factory struct, given that it has no fields and no exposed functions that can be overridden. This PR removes the vararg used by NewFactory for both components, bringing the API in line with what is expected of components. The change is considered a breaking change, however the API signature is the same if the vararg is not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems suspect to offer a FactoryFunc func on both kafka receivers and exporters, when they don't offer any changes to the factory struct, given that it has no fields and no exposed functions that can be overridden.
This PR removes the vararg used by NewFactory for both components, bringing the API in line with what is expected of components. The change is considered a breaking change, however the API signature is the same if the vararg is not used.