vendor perflib in perfcounterscraper #38859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ankitpatel96,
dineshg13,
IbraheemA,
jade-guiton-dd,
liustanley and
mackjmr
dehaansa
approved these changes
Apr 4, 2025
|
Thank you @dehaansa for your help getting the CI passing! |
atoulme
reviewed
Apr 4, 2025
| } | ||
|
|
||
| if err != nil { | ||
| panic(fmt.Sprint("Invalid index ", index)) |
atoulme
approved these changes
Apr 7, 2025
dmathieu
pushed a commit
to dmathieu/opentelemetry-collector-contrib
that referenced
this pull request
Apr 8, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR vendors the `perflib` package from the latest commit of [`windows_exporter`](https://github.com/prometheus-community/windows_exporter). Some constants had to be copied from related packages in `windows_exporter` to make it work. Original license attribution to Prometheus Authors under MIT license is included in this copy. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue open-telemetry#38858 <!--Describe what testing was performed and which tests were added.--> #### Testing Ran tests locally, running integration tests in CI. <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Sam DeHaan <[email protected]>
LucianoGiannotti
pushed a commit
to LucianoGiannotti/opentelemetry-collector-contrib
that referenced
this pull request
Apr 9, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR vendors the `perflib` package from the latest commit of [`windows_exporter`](https://github.com/prometheus-community/windows_exporter). Some constants had to be copied from related packages in `windows_exporter` to make it work. Original license attribution to Prometheus Authors under MIT license is included in this copy. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue open-telemetry#38858 <!--Describe what testing was performed and which tests were added.--> #### Testing Ran tests locally, running integration tests in CI. <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Sam DeHaan <[email protected]>
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR vendors the `perflib` package from the latest commit of [`windows_exporter`](https://github.com/prometheus-community/windows_exporter). Some constants had to be copied from related packages in `windows_exporter` to make it work. Original license attribution to Prometheus Authors under MIT license is included in this copy. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue open-telemetry#38858 <!--Describe what testing was performed and which tests were added.--> #### Testing Ran tests locally, running integration tests in CI. <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Sam DeHaan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR vendors the
perflibpackage from the latest commit ofwindows_exporter. Some constants had to be copied from related packages inwindows_exporterto make it work. Original license attribution to Prometheus Authors under MIT license is included in this copy.Link to tracking issue
#38858
Testing
Ran tests locally, running integration tests in CI.
Documentation