[chore][ping-codeowners-on-new-issue] Process issue even if code owner filed #38841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Mar 20, 2025
atoulme
approved these changes
Mar 20, 2025
edmocosta
approved these changes
Mar 20, 2025
|
this change could also be ported to the scripts in the collector core repo so that they are consistent |
github-merge-queue bot
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Mar 25, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Code owners should be pinged even if a code owner filed an issue. This helps other code owners, in the case of more than one for a single component, be notified of relevant issues being filed. This is the same change as open-telemetry/opentelemetry-collector-contrib#38841, as [requested](open-telemetry/opentelemetry-collector-contrib#38841 (comment)).
github-merge-queue bot
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Mar 27, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Code owners should be pinged even if a code owner filed an issue. This helps other code owners, in the case of more than one for a single component, be notified of relevant issues being filed. This is the same change as open-telemetry/opentelemetry-collector-contrib#38841, as [requested](open-telemetry/opentelemetry-collector-contrib#38841 (comment)).
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…r filed (open-telemetry#38841) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Currently when a code owner files an issue the component's label is not added and the code owners are not pinged. This changes functionality so that even if a code owner files an issue, the component label is added and the code owners are pinged. I investigated this as a result of [confusion because of the existing behavior](open-telemetry#38672 (comment)). Note: If the component is included in the title the label will be properly added to the component even before this change. Pros for this change: - Labels are added automatically - Other code owners (for the case of >1 code owner for a component) are notified of a new issue against their component. Cons for this change: - It might result in noise for the code owner who is filing issues, especially if they're filing in bulk. Alternatives: - We could at least add the label even if a code owner filed the issue. - We could try to remove the filing code owner's handle from the ping message so they don't get pinged, and add a case for not pinging code owners if the user filing is the only code owner. Related: open-telemetry#33437 open-telemetry#30136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when a code owner files an issue the component's label is not added and the code owners are not pinged. This changes functionality so that even if a code owner files an issue, the component label is added and the code owners are pinged. I investigated this as a result of confusion because of the existing behavior.
Note: If the component is included in the title the label will be properly added to the component even before this change.
Pros for this change:
Cons for this change:
Alternatives:
Related:
#33437
#30136