[receiver/sqlserver] fix parsing error on collecting metrics #38823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix here, @cuichenli! Can you please add a changelog entry, marking this as a bug fix? |
crobert-1
changed the title
|
Also, can we add a test here that would have failed before the bug fix? It would be good to ensure this works as intended, and doesn't break in the future. |
|
@crobert-1 thanks for your comment. i have updated the unit test to reflect the float parsing and added one change log. please take a look. |
atoulme
reviewed
Mar 21, 2025
atoulme
approved these changes
Mar 21, 2025
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…lemetry#38823) we are seeing error when parsing value with sqlserver receiver. this pr fixes it and add more descriptive error message. ``` 2025-03-20T10:23:51.127Z error [email protected]/obs_metrics.go:61 Error scraping metrics {"otelcol.component.id": "sqlserver", "otelcol.component.kind": "Receiver", "otelcol.signal": "metrics", "error": "row 1: strconv.ParseInt: parsing "1.8256656e+07": invalid syntax"} ``` --------- Co-authored-by: Antoine Toulme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we are seeing error when parsing value with sqlserver receiver. this pr fixes it and add more descriptive error message.