Skip to content

[cmd/opampsupervisor] Control Collectors with only the OpAMP extension #38809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 30, 2025

Conversation

evan-bradley
Copy link
Contributor

@evan-bradley evan-bradley commented Mar 19, 2025

Description

Right now three components are required for the Supervisor to control a Collector:

  • nopreceiver
  • nopexporter
  • opampextension

The service.AllowNoPipelines feature gate allows the Collector to be started without pipelines, which was released in v0.122.0. This can be used to start the Collector with only the OpAMP extension during the bootstrapping process, obviating the need for the nopreceiver and nopexporter.

@evan-bradley evan-bradley force-pushed the supervisor-no-pipelines branch from 93b3821 to 750435e Compare March 27, 2025 16:01
@evan-bradley evan-bradley force-pushed the supervisor-no-pipelines branch from 1fabd26 to 2c3b037 Compare March 28, 2025 11:33
@evan-bradley evan-bradley marked this pull request as ready for review March 28, 2025 11:36
@evan-bradley evan-bradley requested a review from a team as a code owner March 28, 2025 11:37
@evan-bradley
Copy link
Contributor Author

@atoulme could you take a look at this one? I was hoping to get it in for Monday's release. It should be fairly rigorously tested by the E2E test I added.

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just one nit.

@evan-bradley evan-bradley added the Run Windows Enable running windows test on a PR label Mar 29, 2025
@atoulme atoulme merged commit dfcf308 into open-telemetry:main Mar 30, 2025
207 of 210 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 30, 2025
dmathieu pushed a commit to dmathieu/opentelemetry-collector-contrib that referenced this pull request Apr 8, 2025
open-telemetry#38809)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Right now three components are required for the Supervisor to control a
Collector:
* nopreceiver
* nopexporter
* opampextension

The `service.AllowNoPipelines` feature gate allows the Collector to be
started without pipelines, which was released in v0.122.0. This can be
used to start the Collector with only the OpAMP extension during the
bootstrapping process, obviating the need for the nopreceiver and
nopexporter.

---------

Co-authored-by: Evan Bradley <[email protected]>
Fiery-Fenix pushed a commit to Fiery-Fenix/opentelemetry-collector-contrib that referenced this pull request Apr 24, 2025
open-telemetry#38809)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Right now three components are required for the Supervisor to control a
Collector:
* nopreceiver
* nopexporter
* opampextension

The `service.AllowNoPipelines` feature gate allows the Collector to be
started without pipelines, which was released in v0.122.0. This can be
used to start the Collector with only the OpAMP extension during the
bootstrapping process, obviating the need for the nopreceiver and
nopexporter.

---------

Co-authored-by: Evan Bradley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/opampsupervisor Run Windows Enable running windows test on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants