-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[cmd/opampsupervisor] Control Collectors with only the OpAMP extension #38809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
atoulme
merged 4 commits into
open-telemetry:main
from
evan-bradley:supervisor-no-pipelines
Mar 30, 2025
Merged
[cmd/opampsupervisor] Control Collectors with only the OpAMP extension #38809
atoulme
merged 4 commits into
open-telemetry:main
from
evan-bradley:supervisor-no-pipelines
Mar 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93b3821
to
750435e
Compare
1fabd26
to
2c3b037
Compare
evan-bradley
commented
Mar 28, 2025
evan-bradley
commented
Mar 28, 2025
@atoulme could you take a look at this one? I was hoping to get it in for Monday's release. It should be fairly rigorously tested by the E2E test I added. |
atoulme
reviewed
Mar 28, 2025
atoulme
approved these changes
Mar 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, just one nit.
dmathieu
pushed a commit
to dmathieu/opentelemetry-collector-contrib
that referenced
this pull request
Apr 8, 2025
open-telemetry#38809) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Right now three components are required for the Supervisor to control a Collector: * nopreceiver * nopexporter * opampextension The `service.AllowNoPipelines` feature gate allows the Collector to be started without pipelines, which was released in v0.122.0. This can be used to start the Collector with only the OpAMP extension during the bootstrapping process, obviating the need for the nopreceiver and nopexporter. --------- Co-authored-by: Evan Bradley <[email protected]>
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
open-telemetry#38809) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Right now three components are required for the Supervisor to control a Collector: * nopreceiver * nopexporter * opampextension The `service.AllowNoPipelines` feature gate allows the Collector to be started without pipelines, which was released in v0.122.0. This can be used to start the Collector with only the OpAMP extension during the bootstrapping process, obviating the need for the nopreceiver and nopexporter. --------- Co-authored-by: Evan Bradley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now three components are required for the Supervisor to control a Collector:
The
service.AllowNoPipelines
feature gate allows the Collector to be started without pipelines, which was released in v0.122.0. This can be used to start the Collector with only the OpAMP extension during the bootstrapping process, obviating the need for the nopreceiver and nopexporter.