[reciever/prometheusremotewritereceiver] add help ref #38764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurSens
reviewed
Mar 18, 2025
Comment on lines
+324
to
+327
| // The only difference between ts 0 and 1 is the value assigned in the HelpRef. According to the spec | ||
| // Ref: https://opentelemetry.io/docs/specs/otel/metrics/data-model/#opentelemetry-protocol-data-model, | ||
| // the HelpRef(description) field is not considered an identifying property. | ||
| // This means that if you have two metrics with the same name, unit, scope, and resource attributes but different description values, they are still considered to be the same |
There was a problem hiding this comment.
really really nice find! thanks for paying attention to the spec!
Nope. I was just waiting for your approval to make sure that this make sense. Moving to ready mode ✌🏽 |
ArthurSens
reviewed
Mar 18, 2025
Sorry, I completely forgot it. Adding... |
ArthurSens
approved these changes
Mar 18, 2025
ArthurSens
added
the
ready to merge
atoulme
approved these changes
Mar 18, 2025
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…#38764) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR belongs to part of the Linux foundation mentee program. Here we are adding the help ref attribute to metric following the rules described [here](https://opentelemetry.io/docs/specs/otel/metrics/data-model/#opentelemetry-protocol-data-model-producer-recommendations) <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes part of [open-telemetry#37277](open-telemetry#37277)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR belongs to part of the Linux foundation mentee program.
Here we are adding the help ref attribute to metric following the rules described here
Link to tracking issue
Fixes part of #37277