Skip to content

[receiver/kubeletstats] Collect network metrics from all interfaces #38737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Fiery-Fenix
Copy link
Contributor

Description

Revives #34287 by picking it's changes.
Also changed changed approach from feature gate to configuration parameters (disabled by default).
In context of network metrics - default behavior of component hasn't changed, so I consider it as a non-breaking change.

Link to tracking issue

Fixes #30196

Testing

Unit test were updated to cover new functionality

Documentation

Documentation updated to cover new opt-in functionality

Original authors are included in the commit:
Co-authored-by: ChrsMark [email protected]
Co-authored-by: jinja2 [email protected]

Copy link
Contributor

github-actions bot commented Apr 2, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Apr 2, 2025
@Fiery-Fenix
Copy link
Contributor Author

Fiery-Fenix commented Apr 4, 2025

@dmitryax Could you please take a look while other code owners on vacation?

Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank's for reviving this @Fiery-Fenix and sorry for the delay here. From my perspective I like the idea of having this configurable and not by default enabled so as to ensure that only users that actually need this will enable it.

@TylerHelmuth @jinja2 @povilasv what do you think about this?

@jinja2
Copy link
Contributor

jinja2 commented Apr 16, 2025

Config option sounds good to me. What do we think about renaming the config to collect_all_network_interfaces instead of add_all_interfaces_metrics?

@Fiery-Fenix
Copy link
Contributor Author

Config option sounds good to me. What do we think about renaming the config to collect_all_network_interfaces instead of add_all_interfaces_metrics?

Renamed, new name sounds really better

Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Fiery-Fenix Fiery-Fenix force-pushed the feat/kubelet-network-all-inerfaces branch from b8c94f5 to 4f1f56b Compare April 24, 2025 10:09
@Fiery-Fenix
Copy link
Contributor Author

Sorry for massive ping, accidentally rebased on outdated main branch in fork :(

@ChrsMark
Copy link
Member

@jinja2 @TylerHelmuth @dmitryax @povilasv that should be ready for a review now.

Copy link
Contributor

@jinja2 jinja2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to receiver lgtm, but there are tests failing

@andrzej-stencel andrzej-stencel removed their request for review April 24, 2025 20:43
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax merged commit 154ba2b into open-telemetry:main Apr 24, 2025
189 of 190 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s.pod.network.io gives data only from eth0
6 participants