[receiver/hostmetrics] Add Linux Dirty memory metrics #38673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds metrics to the memory scraper track Dirty memory information reported by /proc/meminfo.
dmitryax
reviewed
Mar 17, 2025
receiver/hostmetricsreceiver/internal/scraper/memoryscraper/metadata.yaml
Outdated
Show resolved
Hide resolved
dmitryax
reviewed
Mar 17, 2025
receiver/hostmetricsreceiver/internal/scraper/memoryscraper/memory_scraper_linux.go
Outdated
Show resolved
Hide resolved
braydonk
changed the title
dmitryax
reviewed
Mar 17, 2025
| component: hostmetricsreceiver | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Added the `system.linux.memory.dirty` and `system.linux.memory.dirty.page.count` metrics. |
dmitryax
reviewed
Mar 17, 2025
| "github.com/shirou/gopsutil/v4/mem" | ||
| "go.opentelemetry.io/collector/pdata/pcommon" | ||
|
|
||
| "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/hostmetricsreceiver/internal/scraper/memoryscraper/internal/metadata" | ||
| ) | ||
|
|
||
| var pageSize = int64(os.Getpagesize()) |
There was a problem hiding this comment.
This is not needed anymore, right?
dmitryax
reviewed
Mar 17, 2025
| @@ -74,3 +83,7 @@ func (s *memoryScraper) scrape(ctx context.Context) (pmetric.Metrics, error) { | |||
|
|
|||
| return s.mb.Emit(), nil | |||
| } | |||
|
|
|||
| func (s *memoryScraper) recordMemoryPageSizeMetric(now pcommon.Timestamp) { | |||
There was a problem hiding this comment.
Not called anywhere looks like :)
|
Whoops yeah I was a bit trigger-happy. Review comments addressed in 2611c50 |
dmitryax
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds metrics to the memory scraper track Dirty memory information reported by /proc/meminfo.
Link to tracking issue
Fixes #38672
Testing
Generated by
mdatagen.Documentation
Unit tests added to cover the new metrics.