[pkg/ottl] Replace key when using function #38626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrik Nyström <[email protected]>
Signed-off-by: Patrik Nyström <[email protected]>
panys9
requested review from
TylerHelmuth,
bogdandrutu,
evan-bradley,
edmocosta and
a team
as code owners
Signed-off-by: Patrik Nyström <[email protected]>
Signed-off-by: Patrik Nyström <[email protected]>
This was referenced Mar 23, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Hi @djaglowski, |
djaglowski
approved these changes
Apr 5, 2025
edmocosta
reviewed
Apr 9, 2025
Signed-off-by: Patrik Nyström <[email protected]>
edmocosta
approved these changes
Apr 10, 2025
TylerHelmuth
approved these changes
Apr 10, 2025
akshays-19
pushed a commit
to akshays-19/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
#### Description When using the `replace_all_patterns` with mode set to `"key"` like `replace_all_patterns(cache, "key", "^(.*)$", "$$1", ToSnakeCase)`. This caused the value to be replaced instead of the key. By replacing the statement updating the value it now work as expected. At least this is how I interpret this function to work. #### Link to tracking issue open-telemetry#32896 #### Testing Added unit test for this scenario since it was missing. #### Documentation --------- Signed-off-by: Patrik Nyström <[email protected]>
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
#### Description When using the `replace_all_patterns` with mode set to `"key"` like `replace_all_patterns(cache, "key", "^(.*)$", "$$1", ToSnakeCase)`. This caused the value to be replaced instead of the key. By replacing the statement updating the value it now work as expected. At least this is how I interpret this function to work. #### Link to tracking issue open-telemetry#32896 #### Testing Added unit test for this scenario since it was missing. #### Documentation --------- Signed-off-by: Patrik Nyström <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the
replace_all_patternswith mode set to"key"likereplace_all_patterns(cache, "key", "^(.*)$", "$$1", ToSnakeCase). This caused the value to be replaced instead of the key. By replacing the statement updating the value it now work as expected. At least this is how I interpret this function to work.Link to tracking issue
#32896
Testing
Added unit test for this scenario since it was missing.
Documentation