kafkatopicsobserver: use configkafka.ClientConfig #38597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the duplicated client config from the Config struct, and embed configkafka.ClientConfig. Remove the duplicated cluster admin client creation code, and use kafka.NewSaramaClientConfig. As a result of this change: - protocol_version is no longer required, it has a default like the other Kafka components do (their READMEs lie, I'll fix those in other PRs) - client_id is now supported, and defaults to "otel-collector" - metadata config is now supported - validation of client config has been removed from this package, since it's covered by validation in the configkafka types
MovieStoreGuy
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the duplicated client config from the Config struct, and embed configkafka.ClientConfig. Remove the duplicated cluster admin client creation code, and use kafka.NewSaramaClientConfig.
As a result of this change:
Link to tracking issue
Part of #38411
Testing
Ran the unit tests.
Documentation
Updated README.