[chore] internal/kafka: introduce configkafka package #38482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
dmitryax,
MovieStoreGuy and
pavolloffay
axw
force-pushed
the
internal-kafka-configkafka
branch
2 times, most recently
from
20bdd35 to
9c2de0c
Compare
axw
force-pushed
the
internal-kafka-configkafka
branch
from
9c2de0c to
e5501e1
Compare
|
Looks like you'll need to run: |
MovieStoreGuy
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first part of #38411, creating a package with common configuration structs for Kafka-related components.
The new types have stronger validation, and all validation is done in one place rather than in each component. I have therefore removed some tests from the components related to validating authentication config, and ensured coverage within internal/kafka.
The configkafka package is complete, but to keep the PR contained I've only updated the components to use the new
AuthenticationConfigtype for now. In future PRs I will:Link to tracking issue
First part of #38411
Testing
Added unit tests.
Documentation
N/A, no user-facing changes yet.