Skip to content

[receiver/rabbitmq] Enhancement/rabbitmq Added node level metrics #38473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

VenuEmmadi
Copy link
Member

Description

This PR enhances the RabbitMQ receiver by adding support for node-level metrics collection. It introduces the ability to individually enable the collection of specific node metrics, including:

  • rabbitmq.node.disk_free: Free disk space on the node.
  • rabbitmq.node.fd_used: The number of file descriptors used on the node.
  • rabbitmq.node.mem_limit: The memory limit on the node.
  • rabbitmq.node.mem_used: The memory used on the node.

This enhancement improves the flexibility and granularity of the metrics collection for RabbitMQ monitoring by allowing users to configure which node metrics to collect.

Link to tracking issue

Fixes #36925

Testing

  • Added unit tests to validate the enabling and disabling of individual node metrics.
  • Verified that each node metric is correctly collected when enabled and omitted when disabled.
  • Ran integration tests to ensure the receiver operates without issues in various configurations.

Documentation

  • Updated the README.md with details about the new per-metric configuration options for enabling node-level metrics.
  • Added examples in config.yaml to demonstrate how to configure the receiver with the new metrics.
  • Included explanations for node-specific metrics in metadata.yaml.

@VenuEmmadi
Copy link
Member Author

Hi @atoulme,
This is the new pull request for the Node metrics implementation, which incorporates the feedback you provided in #37495 . I've resolved all the issues and implemented the necessary changes based on your reviews.

Could you please take a look and provide any further suggestions or feedback?

Thank you!

@atoulme atoulme merged commit aceb1d6 into open-telemetry:main Mar 11, 2025
172 checks passed
@atoulme
Copy link
Contributor

atoulme commented Mar 11, 2025

Please consider applying to become codeowner of this receiver.

@github-actions github-actions bot added this to the next release milestone Mar 11, 2025
atoulme added a commit that referenced this pull request Mar 12, 2025
…eceiver codeowner (#38562)

I have recently worked on this rabbitmq receiver and and we would like
to volunteer to take on the codeowner role.

Worked PR:-
#38473

---------

Co-authored-by: Antoine Toulme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rabbitmqreceiver] Add node level metrics to receiver
3 participants