[pkg/testdata] Add validation functions for test profiles #38452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockdaboot
force-pushed
the
profiles-validate
branch
2 times, most recently
from
113bdf3 to
d2b03de
Compare
rockdaboot
force-pushed
the
profiles-validate
branch
from
d2b03de to
66c9573
Compare
atoulme
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not trivial to see if a test profile is valid or not.
This PR adds
ValidateProfile()to validate a givenpprofile.Profile.The current aim is at artificially generated profiles that are used in tests: using invalid profiles for testing can potentially lead to unwanted results.