[chore] Manual implementation of extensionauth.Client interface #38451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
frzifus,
jamesmoessis,
jpkrohling,
MovieStoreGuy,
pavankrish123 and
VihasMakwana
jamesmoessis
approved these changes
Mar 7, 2025
MovieStoreGuy
approved these changes
Mar 11, 2025
github-merge-queue bot
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Mar 12, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description An attempt at splitting `extensionauth.Client` by protocol type. open-telemetry/opentelemetry-collector-contrib/pull/38451 removes usages of the `NewClient` and `NewServer` constructor --------- Co-authored-by: Jade Guiton <[email protected]>
mx-psi
added a commit
that referenced
this pull request
Mar 13, 2025
…mentions (#38601) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> Follows #38451 and open-telemetry/opentelemetry-collector/pull/12574. Removes explicit mentions to `extensionauth.Client` and replaces them by `extensionauth.HTTPClient` and `extensionauth.GRPCClient`
braydonk
added a commit
to GoogleCloudPlatform/opentelemetry-operations-collector
that referenced
this pull request
Apr 23, 2025
The structure for components in this repo had a fundamental issue. Once we introduced components that were specific to Google-Built OpenTelemetry Collector, we had the issue of otelopscol components targeting an older version of OpenTelemetry. We don't want to force all components to be on the same OTel version; when targeting different distributions, the components need to be at whichever version that distribution is on. This PR restructures the component directories to separate them into two separate directories, one for each distribution the component could be targeting. The Makefile structure is adjusted around this fact. The new process for upating OTel components for a distribution is to go into the Makefile for that distribution's components folder and update the version variables, then in the main directory call the associated target to update those components. This PR also does the OTel version updates for Google-Built OpenTelemetry Collector to prove that the restructure worked effectively. Updates were needed to the client auth extension based on: open-telemetry/opentelemetry-collector-contrib#38451 open-telemetry/opentelemetry-collector-contrib#38601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prepares for addressing changes from open-telemetry/opentelemetry-collector#12574