-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[connector/routing] Add support for standard converter functions in routing conditions #38312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
65ac672
0d425c1
14e18de
5acc996
1607d1b
61575ad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# Use this changelog template to create an entry for release notes. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: enhancement | ||
|
||
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) | ||
component: routingconnector | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Adds `IsString` and `IsMap` to supported functions in routing connector. | ||
|
||
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
issues: [38282] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: | ||
|
||
# If your change doesn't affect end users or the exported elements of any package, | ||
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. | ||
# Optional: The change log or logs in which this entry should be included. | ||
# e.g. '[user]' or '[user, api]' | ||
# Include 'user' if the change is relevant to end users. | ||
# Include 'api' if there is a change to a library API. | ||
# Default: '[user]' | ||
change_logs: [] |
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -19,6 +19,8 @@ func createRouteFunction[K any](_ ottl.FunctionContext, _ ottl.Arguments) (ottl. | |||||||||||||||||||||||
func Functions[K any]() map[string]ottl.Factory[K] { | ||||||||||||||||||||||||
return ottl.CreateFactoryMap( | ||||||||||||||||||||||||
ottlfuncs.NewIsMatchFactory[K](), | ||||||||||||||||||||||||
ottlfuncs.NewIsMapFactory[K](), | ||||||||||||||||||||||||
ottlfuncs.NewIsStringFactory[K](), | ||||||||||||||||||||||||
ottlfuncs.NewDeleteKeyFactory[K](), | ||||||||||||||||||||||||
ottlfuncs.NewDeleteMatchingKeysFactory[K](), | ||||||||||||||||||||||||
// noop function, it is required since the parsing of conditions is not implemented yet, | ||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
I could also see this being an implementation choice, I'll leave it up to the maintainers here if they think that is too much! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the routing connect should have access to all converters. This is safe since converters never change the underlying telemetry itself. @jpkrohling, @mwear @djaglowski do you agree? |
||||||||||||||||||||||||
|
Uh oh!
There was an error while loading. Please reload this page.