Add Cluster Info to Redis Receiver #38285
Conversation
|
Creating this draft PR to get feedback if I am on the right track. Next set of commits would include extraction of all the data included here: https://redis.io/docs/latest/commands/cluster-info/ |
Signed-off-by: Alok Kumar Singh <[email protected]>
Signed-off-by: Alok Kumar Singh <[email protected]>
akstron
force-pushed
the
aloksingh/redis-receiver-cluster-info
branch
from
4c5458c to
f4470d9
Compare
Signed-off-by: Alok Kumar Singh <[email protected]>
Signed-off-by: Alok Kumar Singh <[email protected]>
Signed-off-by: Alok Kumar Singh <[email protected]>
Signed-off-by: Alok Kumar Singh <[email protected]>
|
Hi @dmitryax , can you please provide feedback on the current code structure? |
|
Please add a changelog. Please review my comment and change default behavior to disabled. |
Signed-off-by: Alok Kumar Singh <[email protected]>
Signed-off-by: Alok Kumar Singh <[email protected]>
|
Hi @atoulme , addressed your comments. Thanks |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
| @@ -36,18 +36,21 @@ type Config struct { | |||
| TLS configtls.ClientConfig `mapstructure:"tls,omitempty"` | |||
|
|
|||
| MetricsBuilderConfig metadata.MetricsBuilderConfig `mapstructure:",squash"` | |||
|
|
|||
| ClusterInfoEnabled bool `mapstructure:"cluster_info_enabled"` | |||
There was a problem hiding this comment.
This should be calculated by checking if any of the clusterInfo metrics are enabled.
Otherwise a user could enable the metrics, but disable this flag, and end up not getting the metrics they expect.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description
Adding implementation to retrieve cluster info.
Link to tracking issue
Fixes: #38117
Testing
Not tested yet