-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(telemetrygen): added support for delta temporality #38146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(telemetrygen): added support for delta temporality #38146
Conversation
Thank you @NickAnge! Could you take care of CLA? Here are docs that could help you: https://github.com/open-telemetry/community/blob/main/guides/contributor/CLA.md I know you did some research here, as we have spoken through Slack, and I couldn't answer you. @mx-psi, we were in doubt if, when using deltas, the StartTimestamp should be updated for every datapoint or if we could re-use the same StartTimestamp from the first data point. Could you clarify? While you're at it could you trigger the tests? :) |
The gist of it is that Deltas update StartTimestamp every time, Cumulative keeps the first one. Which means that the current code is not consistent with an usual cumulative timeseries |
95fdd15
to
89bae80
Compare
89bae80
to
56f210f
Compare
Thanks @mx-psi and @ArthurSens . I saw your comment at the issue. Will raise an issue for the cumulative "bug" then. I think the PR is ready for review. Will really appreciate your input. |
Signed-off-by: Nikos Angelopoulos <[email protected]>
* main: (22 commits) [receiver/awsfirehose] Add support for encoding extensions (open-telemetry#37262) fix(deps): update module google.golang.org/api to v0.223.0 (open-telemetry#38181) [chore] skip TestSyslogComplementaryRFC3164 (open-telemetry#38240) fix(deps): update module github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common to v1.0.1106 (open-telemetry#38199) [provider/s3] Use mdatagen, promote to alpha (open-telemetry#38227) fix: fix flaky test in kafkatopicsobserver (open-telemetry#38218) [processor/resourcedetection] Add k8s.cluster.uid to kubeadm detector (open-telemetry#38216) Revert "Add issue generation from fkaly tests for all archs (open-telemetry#38191)" (open-telemetry#38230) Revert "Introduce issuegenerator to open issues when tests fail on main (open-telemetry#38177)" (open-telemetry#38231) [chore] Update otelcol core dependency (open-telemetry#38214) [pkg/stanza] Improve error logs produced by transformer processors (open-telemetry#37285) [receiver/statsd] Make full config structure public (open-telemetry#38186) processor/metricsstarttime: add ridwanmsharif as codeowner (open-telemetry#38193) fix(deps): update module github.com/huaweicloud/huaweicloud-sdk-go-v3 to v0.1.137 (open-telemetry#38154) [pkg/datadog] export StaticAPIKeyCheck (open-telemetry#38223) [chore][pkg/ottl] Move scope and resource PathGetSetters to internal ctx packages (open-telemetry#38225) fix(deps): update all github.com/datadog packages to v0.64.0-rc.3 (open-telemetry#38202) feat(telemetrygen): added support for delta temporality (open-telemetry#38146) [chore] Some more fixes of component IDs (open-telemetry#38221) [chore][pkg/ottl] Define PathGetSetter in ctxdatapoint (open-telemetry#38201) ...
Description
This PR adds support for configuring metric temporality (delta or cumulative) in the telemetrygen tool. This allows users to generate metrics with different temporality types, which is particularly useful for testing different metric collection scenarios.
Changes
temporalityType
flag for metrics pipeline that accepts values:delta
orcumulative
Link to tracking issue
Fixes #38073
Testing
Testing was performed by setting up as simple collector with
otlp
receiver anddebug
exporterSum Datapoint
Histogram Datapoint