[telemetrygen] support --service for all signal types
#38044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag was supported only for traces. It's possible to set the service name via `--otlp-attributes`, but it's more convenient to be able to set it via `--service`. I added it to all signals, but if others disagree with this change, then I would suggest we remove it from all signals. Signed-off-by: Alex Boten <[email protected]>
codeboten
commented
Feb 19, 2025
mx-psi
approved these changes
Feb 19, 2025
Erog38
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag was supported only for traces. It's possible to set the service name via
--otlp-attributes, but it's more convenient to be able to set it via--service. I added it to all signals, but if others disagree with this change, then I would suggest we remove it from all signals.