Skip to content

receiver/prometheusremotewrite: Add two fields timestamp and value. #37895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sujalshah-bit
Copy link
Contributor

Description

Convert sample timestamps from milliseconds to nanoseconds. Set datapoint values using SetDoubleValue based on incoming sample values. Update tests in translateV2 to verify that samples are correctly ingested and their timestamps properly converted.

Link to tracking issue

Fixes part of #37277.

@sujalshah-bit sujalshah-bit requested review from dashpole and a team as code owners February 13, 2025 10:44
Copy link

linux-foundation-easycla bot commented Feb 13, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sujalshah-bit / name: Sujal Shah (b2b7295)

@sujalshah-bit sujalshah-bit force-pushed the handle_timeseries_samples branch 2 times, most recently from bdf5538 to e7c8db3 Compare February 18, 2025 15:17
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just one nit and it should be ready to merge!

@sujalshah-bit sujalshah-bit force-pushed the handle_timeseries_samples branch from e7c8db3 to 2d95426 Compare February 19, 2025 05:21
@sujalshah-bit
Copy link
Contributor Author

Updated the TODO comment kindly review :)

Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit

@sujalshah-bit sujalshah-bit force-pushed the handle_timeseries_samples branch from 2d95426 to ff7a986 Compare February 19, 2025 18:30
@sujalshah-bit
Copy link
Contributor Author

@dashpole made the changes

Convert sample timestamps from milliseconds to nanoseconds. Set
datapoint values using SetDoubleValue based on incoming sample values.
Update tests in translateV2 to verify that samples are correctly
ingested and their timestamps properly converted.

Fixes part of open-telemetry#37277.

Signed-off-by: sujal shah <[email protected]>
@sujalshah-bit sujalshah-bit force-pushed the handle_timeseries_samples branch from ff7a986 to b2b7295 Compare February 19, 2025 18:34
@dashpole dashpole added the ready to merge Code review completed; ready to merge by maintainers label Feb 19, 2025
@songy23 songy23 merged commit 87998c4 into open-telemetry:main Feb 20, 2025
173 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 20, 2025
yiquanzhou added a commit to dash0hq/opentelemetry-collector-contrib that referenced this pull request Feb 24, 2025
* main: (55 commits)
  [chore] Update core dependencies (open-telemetry#38124)
  Add kafka topics observer implementation (open-telemetry#38060)
  [exporter/splunk_hec] Mute errors from draining the response body (open-telemetry#38118)
  [chore] [exporter/splunk_hec] Remove dead code (open-telemetry#38113)
  Add support for JUnit test results (open-telemetry#37941)
  [chore] amend changelog for prometheus receiver change (open-telemetry#38109)
  [chore] Fix dead links in issue-triaging.md (open-telemetry#38105)
  [chore] fix deprecation (open-telemetry#38107)
  [exporter/coralogix] Add new batch options to Coralogix exporter (open-telemetry#38082)
  [chore][exporter/datadog] fix integration test (open-telemetry#38091)
  [chore] Update otel to unblock contrib test in core repo (open-telemetry#38100)
  [chore] Bump go-version match to 1.23 (open-telemetry#38099)
  [exporter/elasticsearch] Add _metric_names_hash to avoid metric rejections (open-telemetry#37511)
  elasticsearchexporter: refactor encoding; drop metrics support from raw/none/bodymap mapping modes (open-telemetry#37928)
  [exporter/stefexporter] Fix incorrectly implemented STEF exporter zstd compression option (open-telemetry#38089)
  [exporter/clickhouse] Add client info for identifying exporter in `system.query_log` (open-telemetry#37146)
  [chore] Prepare release 0.120.1 (open-telemetry#38055)
  [extension/httpforwarder] Shutdown should wait server exit (open-telemetry#37735)
  receiver/prometheusremotewrite: Add two fields timestamp and value. (open-telemetry#37895)
  [reciver/sqlqueryreceiver] Add support for SapASE (sybase) (open-telemetry#37773)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/prometheusremotewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants