Skip to content

prometheusreceiver: deprecate start time adjustment #37879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 18, 2025
Merged

prometheusreceiver: deprecate start time adjustment #37879

merged 5 commits into from
Feb 18, 2025

Conversation

dashpole
Copy link
Contributor

Description

Start time metric adjustment is still enabled by default, but can now be disabled using a feature gate.

It is being replaced by the metricstarttime processor: #37186

Link to tracking issue

Part of #37186

Testing

I updated the unit test for counters

Documentation

Updated the README

@github-actions github-actions bot added the receiver/prometheus Prometheus receiver label Feb 12, 2025
@github-actions github-actions bot requested a review from Aneurysm9 February 12, 2025 15:44
@dashpole dashpole force-pushed the deprecate_adjuster branch 2 times, most recently from e04c2e5 to 239bf2d Compare February 12, 2025 18:40
@dashpole
Copy link
Contributor Author

cc @ridwanmsharif @ArthurSens @jmacd

@dashpole dashpole marked this pull request as ready for review February 12, 2025 18:42
@dashpole dashpole requested a review from a team as a code owner February 12, 2025 18:42
@dashpole dashpole requested a review from codeboten February 12, 2025 18:42
@dashpole dashpole force-pushed the deprecate_adjuster branch 3 times, most recently from 1d04fcc to efafb9f Compare February 12, 2025 20:14
dehaansa
dehaansa reviewed Feb 13, 2025
View reviewed changes
ridwanmsharif
ridwanmsharif approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@ridwanmsharif ridwanmsharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo the renaming to RemoveStartTimeAdjustment or something similar

@dashpole dashpole added the ready to merge Code review completed; ready to merge by maintainers label Feb 18, 2025
@songy23 songy23 merged commit 75f5b58 into open-telemetry:main Feb 18, 2025
173 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 18, 2025
yiquanzhou added a commit to dash0hq/opentelemetry-collector-contrib that referenced this pull request Feb 18, 2025
@yiquanzhou
Merge branch 'main' into kafka-receiver-backoff
0b633b4 
* main: (111 commits)
  fix(azuremonitorreceiver): Azure Monitor receiver should not produce gaps in data points for PT1M time grains (open-telemetry#37342)
  fix(deps): update module sigs.k8s.io/controller-runtime to v0.20.2 (open-telemetry#37996)
  fix(deps): update module github.com/hashicorp/consul/api to v1.31.2 (open-telemetry#38031)
  [processor/resourcedetection] add instructions for recommended use of the dynatrace detector (open-telemetry#37962)
  fix(deps): update module github.com/go-sql-driver/mysql to v1.9.0 (open-telemetry#38007)
  fix(deps): update module google.golang.org/api to v0.221.0 (open-telemetry#38027)
  prometheusreceiver: deprecate start time adjustment (open-telemetry#37879)
  fix(deps): update module github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common to v1.0.1100 (open-telemetry#37995)
  chore(deps): update golang docker tag to v1.24 (open-telemetry#37997)
  fix(deps): update all github.com/aws packages (open-telemetry#37983)
  chore(deps): update prom/prometheus docker tag to v3.2.0 (open-telemetry#37998)
  fix(deps): update kubernetes packages to v0.32.2 (open-telemetry#38004)
  fix(deps): update module github.com/clickhouse/clickhouse-go/v2 to v2.32.1 (open-telemetry#38006)
  fix(deps): update module github.com/google/go-github/v69 to v69.2.0 (open-telemetry#38014)
  fix(deps): update module github.com/sap/go-hdb to v1.13.3 (open-telemetry#38021)
  fix(deps): update module go.etcd.io/bbolt to v1.4.0 (open-telemetry#38024)
  [exporter/stefexporter] Fix a context cancellation bug in STEF exporter (open-telemetry#37944)
  fix(deps): update module github.com/spf13/cobra to v1.9.1 (open-telemetry#38023)
  fix(deps): update module github.com/envoyproxy/go-control-plane/envoy to v1.32.4 (open-telemetry#37990)
  fix(deps): update module github.com/hashicorp/consul/api to v1.31.1 (open-telemetry#37991)
  ...
yiquanzhou added a commit to dash0hq/opentelemetry-collector-contrib that referenced this pull request Feb 19, 2025
@yiquanzhou
Merge branch 'main' into kafka-receiver-backoff
4019f7f 
* main: (111 commits)
  fix(azuremonitorreceiver): Azure Monitor receiver should not produce gaps in data points for PT1M time grains (open-telemetry#37342)
  fix(deps): update module sigs.k8s.io/controller-runtime to v0.20.2 (open-telemetry#37996)
  fix(deps): update module github.com/hashicorp/consul/api to v1.31.2 (open-telemetry#38031)
  [processor/resourcedetection] add instructions for recommended use of the dynatrace detector (open-telemetry#37962)
  fix(deps): update module github.com/go-sql-driver/mysql to v1.9.0 (open-telemetry#38007)
  fix(deps): update module google.golang.org/api to v0.221.0 (open-telemetry#38027)
  prometheusreceiver: deprecate start time adjustment (open-telemetry#37879)
  fix(deps): update module github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common to v1.0.1100 (open-telemetry#37995)
  chore(deps): update golang docker tag to v1.24 (open-telemetry#37997)
  fix(deps): update all github.com/aws packages (open-telemetry#37983)
  chore(deps): update prom/prometheus docker tag to v3.2.0 (open-telemetry#37998)
  fix(deps): update kubernetes packages to v0.32.2 (open-telemetry#38004)
  fix(deps): update module github.com/clickhouse/clickhouse-go/v2 to v2.32.1 (open-telemetry#38006)
  fix(deps): update module github.com/google/go-github/v69 to v69.2.0 (open-telemetry#38014)
  fix(deps): update module github.com/sap/go-hdb to v1.13.3 (open-telemetry#38021)
  fix(deps): update module go.etcd.io/bbolt to v1.4.0 (open-telemetry#38024)
  [exporter/stefexporter] Fix a context cancellation bug in STEF exporter (open-telemetry#37944)
  fix(deps): update module github.com/spf13/cobra to v1.9.1 (open-telemetry#38023)
  fix(deps): update module github.com/envoyproxy/go-control-plane/envoy to v1.32.4 (open-telemetry#37990)
  fix(deps): update module github.com/hashicorp/consul/api to v1.31.1 (open-telemetry#37991)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurSens ArthurSens ArthurSens left review comments

@dehaansa dehaansa dehaansa approved these changes

@ridwanmsharif ridwanmsharif ridwanmsharif approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@songy23 songy23

Labels
ready to merge Code review completed; ready to merge by maintainers receiver/prometheus Prometheus receiver
Projects
None yet
Milestone
v0.120.1
Development

Successfully merging this pull request may close these issues.
5 participants
@dashpole @dehaansa @ridwanmsharif @ArthurSens @songy23