Skip to content

[receiver/syslog] Support setting on_error mode for syslog receiver #37847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

namco1992
Copy link
Contributor

Description

As per the discussion in #36906, this PR supports setting the on_error mode in syslog receiver that controls the behaviour of the underlying syslog_parser when it encounters an error.

Link to tracking issue

Closes #36906.

Testing

Tested setting on_error in the syslog receiver config.

Documentation

Documented the on_error entry in both the syslog input and receiver config.

@namco1992 namco1992 force-pushed the syslog-receiver-add-error-mode branch from 120a979 to fae7716 Compare February 11, 2025 13:46
Copy link
Contributor

@dehaansa dehaansa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@djaglowski djaglowski merged commit 9d7bf1b into open-telemetry:main Feb 13, 2025
162 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 13, 2025
@namco1992 namco1992 deleted the syslog-receiver-add-error-mode branch February 14, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants