Skip to content

[processor/k8sattributes] move k8sattr.fieldExtractConfigRegex.disallow feature gate to stable #37615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jan 31, 2025

Description

move k8sattr.fieldExtractConfigRegex.disallow feature gate to stable which was hiding the FieldExtractConfig.Regex parameter and was deprecated. According to the standards, it can be now moved to stable.

Link to tracking issue

Fixes #25128

@github-actions github-actions bot added the processor/k8sattributes k8s Attributes processor label Jan 31, 2025
@odubajDT odubajDT changed the title [processor/k8sattributes] remove deprecated FieldExtractConfig.Regex parameter [processor/k8sattributes] remove deprecated FieldExtractConfig.Regex parameter Jan 31, 2025
@odubajDT odubajDT marked this pull request as ready for review January 31, 2025 07:55
@odubajDT odubajDT requested a review from a team as a code owner January 31, 2025 07:55
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not sure if 3 releases is too early though. It's fine if we all agree on removing it now.

@odubajDT odubajDT changed the title [processor/k8sattributes] remove deprecated FieldExtractConfig.Regex parameter [processor/k8sattributes] move k8sattr.fieldExtractConfigRegex.disallow feature gate to stable Feb 13, 2025
Signed-off-by: odubajDT <[email protected]>
@TylerHelmuth TylerHelmuth merged commit e7148d5 into open-telemetry:main Feb 18, 2025
162 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/k8sattributes k8s Attributes processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[processor/k8sattributes] Deprecate and remove FieldExtractConfig.Regex config option
4 participants