[receiver/googlecloudpubsub] Turn noisy warn in reset metric (#37571) #37583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvanboxel
force-pushed
the
pubsubreceiver-resetmetric
branch
9 times, most recently
from
5466619 to
51ac85d
Compare
mx-psi
reviewed
Feb 3, 2025
Comment on lines
+98
to
+99
| attribute.String("otelcol.component.kind", "receiver"), | ||
| attribute.String("otelcol.component.id", handler.settings.ID.String()), |
There was a problem hiding this comment.
@djaglowski do the attributes here look good?
alexvanboxel
force-pushed
the
pubsubreceiver-resetmetric
branch
from
51ac85d to
ce9c1be
Compare
alexvanboxel
force-pushed
the
pubsubreceiver-resetmetric
branch
from
ce9c1be to
3e893b0
Compare
|
Rebased (and re-generated new code though |
mx-psi
approved these changes
Feb 5, 2025
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Feb 8, 2025
…lemetry#37571) (open-telemetry#37583) #### Description The receiver uses the Google Cloud Pub/Sub StreamingPull API and keeps a open connection. The Pub/Sub servers recurrently close the connection after a time period to avoid a long-running sticky connection. Before the receiver logged `warn` log lines everytime this happened. These log lines are moved to debug so that fleets with lots of collectors with the receiver don't span logs at warn level. To keep track of the resets, whenever a connection reset happens a `otelcol_receiver_googlecloudpubsub_stream_restarts` metric is increased by one. #### Link to tracking issue Fixes 37571 #### Documentation Documentation is auto generated for the metric
zeck-ops
pushed a commit
to zeck-ops/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…lemetry#37571) (open-telemetry#37583) #### Description The receiver uses the Google Cloud Pub/Sub StreamingPull API and keeps a open connection. The Pub/Sub servers recurrently close the connection after a time period to avoid a long-running sticky connection. Before the receiver logged `warn` log lines everytime this happened. These log lines are moved to debug so that fleets with lots of collectors with the receiver don't span logs at warn level. To keep track of the resets, whenever a connection reset happens a `otelcol_receiver_googlecloudpubsub_stream_restarts` metric is increased by one. #### Link to tracking issue Fixes 37571 #### Documentation Documentation is auto generated for the metric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The receiver uses the Google Cloud Pub/Sub StreamingPull API and keeps a open connection. The Pub/Sub servers
recurrently close the connection after a time period to avoid a long-running sticky connection. Before the
receiver logged
warnlog lines everytime this happened. These log lines are moved to debug so that fleets withlots of collectors with the receiver don't span logs at warn level. To keep track of the resets, whenever a
connection reset happens a
otelcol_receiver_googlecloudpubsub_stream_restartsmetric is increased by one.Link to tracking issue
Fixes 37571
Documentation
Documentation is auto generated for the metric