Skip to content

[receiver/github] add workflow run event trace handling #37578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Feb 11, 2025

Conversation

adrielp
Copy link
Contributor

@adrielp adrielp commented Jan 29, 2025

Description

Adds functionality for creating a deterministic trace id and root span id coming from the workflow runs.

Link to tracking issue

Relates to #34944

Testing

Added tests and deployed locally.

Documentation

Updated the README to contain information about tracing.

@adrielp adrielp marked this pull request as ready for review February 3, 2025 01:32
@adrielp adrielp requested a review from a team as a code owner February 3, 2025 01:32
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just nits, looks good overall 👍

@adrielp adrielp requested a review from crobert-1 February 4, 2025 15:10
@adrielp adrielp requested a review from crobert-1 February 6, 2025 19:27
@adrielp
Copy link
Contributor Author

adrielp commented Feb 6, 2025

Known workflow failure in latest run. Issue #37757

Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more nits. Feel free to drop/change as you see fit 👍

@adrielp adrielp requested a review from crobert-1 February 7, 2025 19:12
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for all of your work here!

@mx-psi
Copy link
Member

mx-psi commented Feb 11, 2025

Can you fix the merge conflicts? Happy to merge after that

@adrielp
Copy link
Contributor Author

adrielp commented Feb 11, 2025

Can you fix the merge conflicts? Happy to merge after that

Resolved. Workflows are running now.

Workflows are green ✅

@mx-psi mx-psi merged commit 889b47f into open-telemetry:main Feb 11, 2025
162 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 11, 2025
@adrielp adrielp deleted the gh-tracing branch February 11, 2025 16:10
yiquanzhou added a commit to dash0hq/opentelemetry-collector-contrib that referenced this pull request Feb 11, 2025
* main: (76 commits)
  Update All OpenTelemetry Collector Contrib packages (open-telemetry#37839)
  [chore] fix codeowners allowlist (open-telemetry#37856)
  Update module github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp to v1.26.0 (open-telemetry#37841)
  Update module github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common to v1.0.1095 (open-telemetry#37825)
  Update module github.com/grpc-ecosystem/grpc-gateway/v2 to v2.26.1 (open-telemetry#37821)
  [chore][exporter/elasticsearch] Bump go-docappender to v2.5.0 (open-telemetry#37852)
  Update All github.com/aws packages (open-telemetry#37816)
  Update module google.golang.org/protobuf to v1.36.5 (open-telemetry#37827)
  Update module github.com/SAP/go-hdb to v1.12.12 (open-telemetry#37817)
  Update module github.com/huaweicloud/huaweicloud-sdk-go-v3 to v0.1.135 (open-telemetry#37822)
  Update module github.com/ClickHouse/clickhouse-go/v2 to v2.31.0 (open-telemetry#37835)
  [receiver/datadog] Implement support for span links (open-telemetry#37449)
  receiver/prometheusreceiver: allow cumulative resets when using the adjuster (open-telemetry#37718)
  Update README.md (open-telemetry#37826)
  [receiver/github] add workflow run event trace handling (open-telemetry#37578)
  Update All github.com/datadog packages to v0.62.2 (open-telemetry#37838)
  [chore] Update types used in extensiontest.NewNopSettingsWithType (open-telemetry#37844)
  [processor/redaction] introduce `allowed_values` parameter in processor config (open-telemetry#37638)
  [chore] Update otel version (open-telemetry#37808)
  [testbed] Include CPU and memory limits to benchmark results file (open-telemetry#36753)
  ...
khushijain21 pushed a commit to khushijain21/opentelemetry-collector-contrib that referenced this pull request Feb 14, 2025
…ry#37578)

#### Description

Adds functionality for creating a deterministic trace id and root span
id coming from the workflow runs.

#### Link to tracking issue

Relates to open-telemetry#34944 

#### Testing

Added tests and deployed locally.

#### Documentation

Updated the README to contain information about tracing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants