Skip to content

[processor/tailsampling] allow setting only min_value or max_value for the numeric_attribute #37328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 8, 2025

Conversation

bmbferreira
Copy link
Contributor

Description

This PR makes the numeric_attribute more flexible and allows to set only min_value or max_value, without the need to set both. This is useful to have simple configurations like these:

{
  type: numeric_attribute,
  numeric_attribute: {
    key: http.status_code,
    min_value: 400
  }
}

Link to tracking issue

N/A

Testing

Added unit tests to cover all changes and scenarios.

Documentation

I fixed an example on the documentation to have just the min_value set

@github-actions github-actions bot added the processor/tailsampling Tail sampling processor label Jan 20, 2025
@bmbferreira
Copy link
Contributor Author

I've put it on draft because some things are still missing from the contributing guide

@bmbferreira
Copy link
Contributor Author

I've put it on draft because some things are still missing from the contributing guide

fixed the remaining issues and it's ready for review now.

@bmbferreira bmbferreira marked this pull request as ready for review January 22, 2025 00:12
@bmbferreira bmbferreira requested a review from a team as a code owner January 22, 2025 00:12
Copy link
Contributor

github-actions bot commented Feb 5, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 5, 2025
@jpkrohling jpkrohling merged commit d1d4d69 into open-telemetry:main Feb 8, 2025
167 checks passed
@jpkrohling
Copy link
Member

Thank you!

@github-actions github-actions bot added this to the next release milestone Feb 8, 2025
@bmbferreira
Copy link
Contributor Author

Thank you!

🙏 obrigado

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/tailsampling Tail sampling processor Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants