-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[pkg/ottl] add event_index to available paths in span event context #37092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TylerHelmuth
merged 32 commits into
open-telemetry:main
from
bacherfl:feat/35778/ottl-event-index
Feb 24, 2025
Merged
[pkg/ottl] add event_index to available paths in span event context #37092
TylerHelmuth
merged 32 commits into
open-telemetry:main
from
bacherfl:feat/35778/ottl-event-index
Feb 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
…nto feat/35778/ottl-event-index
Signed-off-by: Florian Bacher <[email protected]>
evan-bradley
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just one note.
Co-authored-by: Evan Bradley <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
# Conflicts: # pkg/ottl/contexts/ottlspanevent/span_events.go
edmocosta
reviewed
Jan 16, 2025
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
TylerHelmuth
approved these changes
Feb 18, 2025
Need to handle merge conflict otherwise looks good. |
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
edmocosta
reviewed
Feb 21, 2025
edmocosta
approved these changes
Feb 24, 2025
Co-authored-by: Edmo Vamerlatti Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
event_index
to the available paths in the span event contextLink to tracking issue
Fixes #35778
Testing
Unit tests, e2e tests
Documentation
added an entry in the list of available paths in the readme of then span event context