[receiver/kafkametrics] Fix incorrect cluster admin initialization in consumer scraper #36818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurytaranau
force-pushed
the
fix/kafkametricsreceiver
branch
2 times, most recently
from
56c7d8c to
2d15b92
Compare
|
@dmitryax, please take a look |
…itialization in consumer scraper
yurytaranau
force-pushed
the
fix/kafkametricsreceiver
branch
from
2d15b92 to
34642b3
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@MovieStoreGuy @dmitryax, could you please take a look? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Sorry for the delay. Missed it |
dmitryax
approved these changes
Feb 18, 2025
csatib02
pushed a commit
to axoflow/opentelemetry-collector-contrib
that referenced
this pull request
Feb 18, 2025
… consumer scraper (open-telemetry#36818) #### Description Fix the issue with incorrect cluster admin initialization in consumer scraper. It might happen if client is alive, but ClusterAdmin is already closed. As a result it can lead to `write: connection reset by peer` errors. Co-authored-by: Dmitrii Anoshin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the issue with incorrect cluster admin initialization in consumer scraper. It might happen if client is alive, but ClusterAdmin is already closed. As a result it can lead to
write: connection reset by peererrors.Link to tracking issue
none
Testing
none
Documentation
none