Skip to content

datadogexporter: read response body on pushSketches #36779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 16, 2024
Merged

datadogexporter: read response body on pushSketches #36779

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b265c3b
datadogexporter: read response body on pushSketches
Dec 11, 2024
735bddf
Add changelog.
Dec 11, 2024
7e72de3
Missing import.
Dec 12, 2024
c65bf5e
Handle error on body read.
Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions exporter/datadogexporter/metrics_exporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,10 @@
}
defer resp.Body.Close()

// We must read the full response body from the http request to ensure that connections can be
// properly re-used. https://pkg.go.dev/net/http#Client.Do
_, err = io.Copy(io.Discard, resp.Body)

Check failure on line 159 in exporter/datadogexporter/metrics_exporter.go

View workflow job for this annotation

GitHub Actions / govulncheck (exporter-1) 

undefined: io

Check failure on line 159 in exporter/datadogexporter/metrics_exporter.go

View workflow job for this annotation

GitHub Actions / govulncheck (exporter-1) 

undefined: io

if resp.StatusCode >= 400 {
return clientutil.WrapError(fmt.Errorf("error when sending payload to %s: %s", sketches.SketchSeriesEndpoint, resp.Status), resp)
}
Expand Down
Loading