Skip to content

[chore] Enable goleak oidcauthextension #35282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

iblancasa
Copy link
Contributor

Related to #30438

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will need a rebase

@iblancasa iblancasa requested a review from a team as a code owner September 19, 2024 11:11
@github-actions github-actions bot requested a review from pavolloffay October 1, 2024 09:20
@iblancasa
Copy link
Contributor Author

Can somebody from @collector-contrib-approvers take a look?

Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth adding a changelog here: This is fixing a bug in the extension, so we can let users know that we're fixing a memory leak here.

@iblancasa iblancasa force-pushed the enable-goleak-oidcauthextension branch from 5f53269 to 6616eab Compare October 3, 2024 18:29
@MovieStoreGuy MovieStoreGuy merged commit aa89dc7 into open-telemetry:main Oct 9, 2024
155 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 9, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
Related to open-telemetry#30438

---------

Signed-off-by: Israel Blancas <[email protected]>
Co-authored-by: Curtis Robert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants