Improve kubeletstats receiver logging #352
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubeletstats receiver was missing log statements on important errors.
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
==========================================
+ Coverage 82.62% 82.66% +0.03%
==========================================
Files 170 170
Lines 9049 9052 +3
==========================================
+ Hits 7477 7483 +6
+ Misses 1248 1246 -2
+ Partials 324 323 -1
Continue to review full report at Codecov.
|
pmcollins
changed the title
|
Replacing with PR #357 |
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Add Min() interface - rename MaxSumCount to MinMaxSumCount Fixes open-telemetry/opentelemetry-go#319 * update stdout exporter to collect and output the minimum value * update min and max atomically in Aggregator Update * changed all references to maxsumcount to minmaxsumcount * Address PR comments
bogdandrutu
pushed a commit
that referenced
this pull request
May 12, 2022
* Bump gosec * Pin compatible versions of golangci-lint and gosec in tools
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubeletstats receiver was missing log statements on important errors.