-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(datadogexporter): adds remap_metrics feature gate #35025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datadogexporter): adds remap_metrics feature gate #35025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need to be a config, i.e. when does a customer want to disable it?
If this is only for internal migration to semantic core, we don't need to expose it
It is internal to semantic-core. Good point we should avoid updating documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I still don't quite understand why we need this PR. I think doing the remapping is mandatory, remapping should never be turned off at any time, otherwise users will have broken user experience. It is an implementation detail how we do the remapping and end users probably wouldn't care
Good point. We need a mechanism to disable remapping in the Exporter so we can handle this logic in a Processor. Remapping will always occur we are just changing where this can happen. End user's will not set this configuration. I will move this change back to a draft state and update this PR to use a feature gate instead. |
This reverts commit 4e32791.
keep this change internal
9e31b0f
to
8bbbc5a
Compare
@songy23 How should I test this change? |
You can follow the similar in DataDog/datadog-agent#28228 (review) with |
Co-authored-by: Yang Song <[email protected]>
Co-authored-by: Yang Song <[email protected]>
c2e417e
to
fcd9aad
Compare
fcd9aad
to
b38e973
Compare
Co-authored-by: Pablo Baeyens <[email protected]>
…y#35025) **Description:** <Describe what has changed.> Adds a metrics configuration that enables/disables the conversion of OpenTelemetry metrics to Datadog semantics in the Datadog Exporter. This conversion will soon occur in a datadog semantic processor. **Link to tracking Issue:** N/A **Testing:** Unit tests *̶*̶D̶o̶c̶u̶m̶e̶n̶t̶a̶t̶i̶o̶n̶:̶*̶*̶ O̶n̶c̶e̶ t̶h̶i̶s̶ c̶o̶n̶f̶i̶g̶u̶r̶a̶t̶i̶o̶n̶ i̶s̶ G̶A̶ w̶e̶ w̶i̶l̶l̶ u̶p̶d̶a̶t̶e̶ t̶h̶e̶ d̶o̶c̶s̶ h̶e̶r̶e̶:̶ h̶t̶t̶p̶s̶:̶//d̶o̶c̶s̶.d̶a̶t̶a̶d̶o̶g̶h̶q̶.c̶o̶m̶/o̶p̶e̶n̶t̶e̶l̶e̶m̶e̶t̶r̶y̶/c̶o̶l̶l̶e̶c̶t̶o̶r̶_̶e̶x̶p̶o̶r̶t̶e̶r̶/c̶o̶n̶f̶i̶g̶u̶r̶a̶t̶i̶o̶n̶/ --------- Co-authored-by: Yang Song <[email protected]> Co-authored-by: Pablo Baeyens <[email protected]>
Description:
Adds a metrics configuration that enables/disables the conversion of OpenTelemetry metrics to Datadog semantics in the Datadog Exporter. This conversion will soon occur in a datadog semantic processor.
Link to tracking Issue: N/A
Testing: Unit tests
̶̶D̶o̶c̶u̶m̶e̶n̶t̶a̶t̶i̶o̶n̶:̶̶̶ O̶n̶c̶e̶ t̶h̶i̶s̶ c̶o̶n̶f̶i̶g̶u̶r̶a̶t̶i̶o̶n̶ i̶s̶ G̶A̶ w̶e̶ w̶i̶l̶l̶ u̶p̶d̶a̶t̶e̶ t̶h̶e̶ d̶o̶c̶s̶ h̶e̶r̶e̶:̶ h̶t̶t̶p̶s̶:̶//d̶o̶c̶s̶.d̶a̶t̶a̶d̶o̶g̶h̶q̶.c̶o̶m̶/o̶p̶e̶n̶t̶e̶l̶e̶m̶e̶t̶r̶y̶/c̶o̶l̶l̶e̶c̶t̶o̶r̶_̶e̶x̶p̶o̶r̶t̶e̶r̶/c̶o̶n̶f̶i̶g̶u̶r̶a̶t̶i̶o̶n̶/