Skip to content

[receiver/simpleprometheus] Support customizing job name #34408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chenlujjj
Copy link
Contributor

@chenlujjj chenlujjj commented Aug 5, 2024

Description:

Resolve #31502

Link to tracking Issue: 31502

@chenlujjj chenlujjj force-pushed the feat/support-custom-jobname branch from 8ee161a to d7cd6e1 Compare August 6, 2024 02:33
@chenlujjj
Copy link
Contributor Author

Hi @fatsheep9146 , the CI has passed, could you pls review? Thanks

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 20, 2024
@chenlujjj
Copy link
Contributor Author

hi @fatsheep9146 kind reminder

@github-actions github-actions bot removed the Stale label Aug 21, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 4, 2024
@atoulme atoulme removed the Stale label Sep 4, 2024
@dashpole
Copy link
Contributor

@fatsheep9146 are you able to review?

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 10, 2024
@chenlujjj
Copy link
Contributor Author

not stale,
Can anyone help to assign the reviewer ?

@github-actions github-actions bot removed the Stale label Oct 11, 2024
@dashpole dashpole added the ready to merge Code review completed; ready to merge by maintainers label Oct 23, 2024
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me, pinging @fatsheep9146 as the code owner for a review

@andrzej-stencel andrzej-stencel merged commit c860d1d into open-telemetry:main Oct 30, 2024
180 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 30, 2024
zzhlogin pushed a commit to zzhlogin/opentelemetry-collector-contrib-aws that referenced this pull request Nov 12, 2024
…try#34408)

**Description:** <Describe what has changed.>

Resolve
open-telemetry#31502


**Link to tracking Issue:** 31502
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…try#34408)

**Description:** <Describe what has changed.>

Resolve
open-telemetry#31502


**Link to tracking Issue:** 31502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/simpleprometheus waiting-for-code-owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[simple prometheus receiver]Support customized job name in configuration
7 participants