Skip to content

[connector/datadog] Respect _dd.measured and eligible span kind when native ingest is enabled #34197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 29, 2024
Merged

[connector/datadog] Respect _dd.measured and eligible span kind when native ingest is enabled #34197

merged 7 commits into from
Jul 29, 2024

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Jul 22, 2024

When feature gate connector.datadogconnector.NativeIngest is enabled:

  1. Spans with attribute _dd.measured: 1 should always get APM stats
  2. When the new enable_otlp_compute_top_level_by_span_kind feature is enabled, non-root spans with client or producer span kind should get stats

@songy23 songy23 requested a review from mx-psi as a code owner July 22, 2024 20:09
@songy23 songy23 requested a review from a team July 22, 2024 20:09
@github-actions github-actions bot added cmd/otelcontribcol otelcontribcol command connector/datadog exporter/datadog Datadog components labels Jul 22, 2024
dineshg13
dineshg13 reviewed Jul 26, 2024
View reviewed changes
dineshg13
dineshg13 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@dineshg13 dineshg13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good expect one comment

@mx-psi mx-psi merged commit 0393a45 into open-telemetry:main Jul 29, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 29, 2024
@songy23 songy23 deleted the dd-deps branch July 29, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dineshg13 dineshg13 dineshg13 approved these changes

@mx-psi mx-psi mx-psi approved these changes

@ankitpatel96 ankitpatel96 Awaiting requested review from ankitpatel96

@liustanley liustanley Awaiting requested review from liustanley

@mackjmr mackjmr Awaiting requested review from mackjmr

Assignees

@mx-psi mx-psi

Labels
cmd/otelcontribcol otelcontribcol command connector/datadog exporter/datadog Datadog components
Projects
None yet
Milestone
v0.106.0
Development

Successfully merging this pull request may close these issues.
3 participants
@songy23 @dineshg13 @mx-psi