[exporter/datadog] Fix duplicate sent log records in logs agent exporter #33887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ankitpatel96,
dineshg13,
mackjmr,
mx-psi and
songy23
songy23
reviewed
Jul 3, 2024
There was a problem hiding this comment.
Could you add an integration test to validate it? You'll need to add a handler for api/v2/series in https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/datadogexporter/internal/testutil/logs.go#L42 then use the DatadogLogsServer
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
songy23
added
never stale
songy23
reviewed
Jul 23, 2024
exporter/datadogexporter/integrationtest/integration_test_logs_config.yaml
Show resolved
Hide resolved
exporter/datadogexporter/integrationtest/integration_test_logs_config.yaml
Outdated
Show resolved
Hide resolved
songy23
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We were calling
exporterhelper.NewLogsExportertwice when instantiating the logs agent exporter: once in the datadogexporter factory method and once in the logs agent exporter factory method. This resulted in theotelcol_exporter_sent_log_recordsreporting double the amount of logs being sent. This PR removes the latter call by usinglogsagentexporter.NewExporterdirectly.Link to tracking Issue:
Testing:
Verified locally that
otelcol_exporter_sent_log_recordsreports the correct number of sent logs now, and added integration test.Documentation: