Skip to content

[chore][receiver/snowflake] Enable goleak check #32182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2024
Merged

[chore][receiver/snowflake] Enable goleak check #32182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c09feb
[chore][receiver/snowflake] Enable goleak checks
crobert-1 Apr 4, 2024
de4fefc
Add goleak ignore
crobert-1 Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions receiver/snowflakereceiver/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (
)

func TestDefaultClientCreation(t *testing.T) {
_, err := newDefaultClient(componenttest.NewNopTelemetrySettings(), Config{
c, err := newDefaultClient(componenttest.NewNopTelemetrySettings(), Config{
Username: "testuser",
Password: "testPassword",
Account: "testAccount",
Expand All @@ -27,7 +27,8 @@ func TestDefaultClientCreation(t *testing.T) {
Database: "testDatabase",
Role: "testRole",
})
assert.Equal(t, nil, err)
assert.NoError(t, err)
assert.NoError(t, c.client.Close())
}

// test query wrapper
Expand Down
15 changes: 15 additions & 0 deletions receiver/snowflakereceiver/package_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

package snowflakereceiver

import (
"testing"

"go.uber.org/goleak"
)

// Regarding the godbus/dbus ignore: see https://github.com/99designs/keyring/issues/103
func TestMain(m *testing.M) {
goleak.VerifyTestMain(m, goleak.IgnoreAnyFunction("github.com/godbus/dbus.(*Conn).inWorker"))
}
1 change: 1 addition & 0 deletions receiver/snowflakereceiver/scraper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ func TestStart(t *testing.T) {
scraper := newSnowflakeMetricsScraper(receivertest.NewNopCreateSettings(), cfg)
err := scraper.start(context.Background(), componenttest.NewNopHost())
require.NoError(t, err, "Problem starting scraper")
require.NoError(t, scraper.shutdown(context.Background()))
}

// wrapper type for convenience
Expand Down