Skip to content

collectd receiver should not report ErrServerClosed #3178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pjanotti
Copy link
Contributor

The collectord receiver reports ErrServerClosed when shutting down the service. This error is expected and should not be reported.

@pjanotti pjanotti requested a review from owais as a code owner April 20, 2021 06:26
@pjanotti pjanotti requested a review from a team April 20, 2021 06:26
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #3178 (187f4ea) into main (677990d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3178      +/-   ##
==========================================
- Coverage   91.92%   91.92%   -0.01%     
==========================================
  Files         493      493              
  Lines       23936    23936              
==========================================
- Hits        22004    22002       -2     
- Misses       1427     1428       +1     
- Partials      505      506       +1     
Flag Coverage Δ
integration 63.63% <ø> (+0.36%) ⬆️
unit 90.93% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
receiver/collectdreceiver/receiver.go 68.49% <0.00%> (-2.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 677990d...187f4ea. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 1168df2 into open-telemetry:main Apr 20, 2021
pmatyjasek-sumo pushed a commit to pmatyjasek-sumo/opentelemetry-collector-contrib that referenced this pull request Apr 28, 2021
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
@pjanotti pjanotti deleted the collectdreceiver-ignore-err-server-closed branch September 28, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants